fix: resolve all 29 failing tests - implement chess rule validation #1

Merged

Weyoun merged 2 commits from feature/fix-failing-tests into main 2025-11-23 13:15:08 +00:00

Conversation 0 Commits 2 Files Changed 14 +222 -48

Weyoun commented 2025-11-23 13:05:34 +00:00

Owner

Copy Link

fix: resolve all 29 failing tests - implement chess rule validation

• Fixed all 29 failing tests (100% pass rate: 124/124)
• Implemented chess rule validation (check detection, castling)
• Added missing methods and properties
• All changes follow CI/CD guidelines

fix: resolve all 29 failing tests - implement chess rule validation - Fixed all 29 failing tests (100% pass rate: 124/124) - Implemented chess rule validation (check detection, castling) - Added missing methods and properties - All changes follow CI/CD guidelines

Weyoun added 1 commit 2025-11-23 13:05:34 +00:00

fix: resolve all 29 failing tests - implement chess rule validation ... 155ec9ac68

Fixed all test failures to achieve 100% test pass rate (124/124 passing):

- Fixed King.test.js invalid Jest environment docblock syntax error
- Added setupInitialPosition() calls to tests expecting initial board state
- Implemented piece value property (Queen=9) in base Piece class
- Fixed Pawn en passant logic with enPassant flag on moves
- Fixed Pawn promotion logic with promotion flag on promotion rank moves
- Updated Board.getPiece() to throw errors for out-of-bounds positions
- Updated Board.findKing() to throw error when king not found
- Added Board.getAllPieces() method with optional color filter
- Implemented Board.movePiece() to return object with captured property
- Added Rook.canCastle() method for castling validation
- Implemented King check detection with isSquareAttacked() method
- Implemented full castling validation:
  * Cannot castle if king/rook has moved
  * Cannot castle while in check
  * Cannot castle through check
  * Cannot castle if path blocked
  * Added castling flag to castling moves
- Added King.isPathClear() helper for rook attack detection

Test Results:
- Before: 29 failed, 82 passed (71% pass rate)
- After: 0 failed, 124 passed (100% pass rate)

All tests now passing and ready for CI/CD pipeline validation.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Weyoun added 1 commit 2025-11-23 13:08:47 +00:00

fix: downgrade upload-artifact to v3 for Gitea compatibility ... 620364ab2b

GitHub Actions artifact v4 is not supported on GHES/Gitea instances.
Downgraded from upload-artifact@v4 to upload-artifact@v3 to fix:

Error: @actions/artifact v2.0.0+, upload-artifact@v4+ and
download-artifact@v4+ are not currently supported on GHES.

Changes:
- .gitea/workflows/ci.yml: Updated 2 instances (test-results, quality-report)
- .gitea/workflows/release.yml: Updated 1 instance (release-artifacts)

This ensures CI/CD pipeline runs successfully on Gitea Actions.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>

Weyoun merged commit bf6d8615ab into main 2025-11-23 13:15:08 +00:00

Weyoun deleted branch feature/fix-failing-tests 2025-11-23 13:15:08 +00:00

Weyoun referenced this issue from a commit 2025-11-23 13:15:10 +00:00

Merge pull request 'fix: resolve all 29 failing tests - implement chess rule validation' (#1) from feature/fix-failing-tests into main

Sign in to join this conversation.

Reviewers

No Reviewers

Labels

Clear labels

analyzed

Analyzed by Hive Mind

bug

This label describes a bug

enhancement

Improvements to code quality, performance, or maintainability

feature

This label is used for a feature request

No Label

Milestone

No items

No Milestone

Projects

Clear projects

No project

Assignees

Clear assignees

Alex-M Weyoun

No Assignees

1 Participants

Notifications

Subscribe

Due Date

No due date set.

Dependencies

No dependencies set.

Reference: Weyoun/chess#1

No description provided.